[R-package] deprecate lgb.prepare() and lgb.prepare2() #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
force-pushed
the
r/deprecate-prepare
branch
from
a26f7b7
to
937edfa
Compare
|
gently ping @Laurae2 for a review |
Laurae2
suggested changes
Jun 4, 2020
jameslamb
force-pushed
the
r/deprecate-prepare
branch
from
937edfa
to
51c349e
Compare
|
@jameslamb please check my comments inline. |
|
I just merged |
|
I've merged in the changes from #3188 . This is ready for review. |
StrikerRUS
approved these changes
Jul 29, 2020
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Laurae2
suggested changes
Jul 29, 2020
|
@StrikerRUS have you also seen this recently on AppVeyor?
|
Nope... |
ok, hopefully it was just something transient. I don't see any incidents on AppVeyor: https://status.appveyor.com/ |
Laurae2
approved these changes
Aug 1, 2020
This was referenced Aug 1, 2020
Closed
Closed
Closed
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3075 .
lgb.prepare()andlgb.prepare2()have a lot of code overlap and it could be confusing to know which one to use.To reduce the public API of the R package and make it easier for uses to understand how too get from their raw data to a trained model, this PR deprecates
lgb.prepare()andlgb.prepare_rules()in favor oflgb.prepare2()andlgb.prepare_rules2(). They'll be removed completely in LightGBM 3.0.0 (#3071 )